fix: PHPStan 1.9.0 compatibility #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
force-pushed
the
1.9.x
branch
3 times, most recently
from
1e978ae
to
df1e3e6
Compare
|
Is it possible to apply that patch also to 1.0.3? We still need to use that version because we haven't yet switched to Laravel 9.x. |
|
No. 1.x releases are not maintained any more. It lacks a lot of fixes, not just this one. You can use your own fork with this fix though. |
|
Ok, we can do that, but I think the better approach would be to upgrade Laravel as soon as possible. Thanks for the fast reply. |
|
I've also got a few Laravel 8 projects and I'm hitting this issue. It would be appreciated if it could be backported, or at least make Larastan 1.x block PHPStan 1.9 so it doesn't completely break. |
|
@NickStallman Hello! Thank you for commenting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PHPStan 1.9.x compatibility.