Add support for request helper

[j3j5]

Add support for the request() helper.

This is my first significant contribution to phpstan/larastan so all feedback is welcome.

[szepeviktor]

Looks very nice. Does it work?
BTW Larastan's code is checked by PHPStan ;-)

[j3j5]

I've tested it on one of my projects where I was getting all those errors Cannot call method input() on array|Illuminate\Http\Request|string when using request()->input('key') and it works, but it never hurts to have more eyeballs look at it :)

[szepeviktor]

Thank you for your contribution!

[nunomaduro]

@j3j5 Thank you so much for this contribution, do you mind of address my feedback?

[nunomaduro]

Shouldn't this be only return new ArrayType() ?

[j3j5]

Looking at the constructor I didn't think it was possible, but I just tested it and it works. What are the values of Type $keyType and Type $itemType when you construct the object w/o arguments?

[nunomaduro]

When $key is an array the request helper returns the result of the method only:

        if (is_array($key)) {
            return app('request')->only($key);
        }

And the only method returns an array:

    /**
     * Get a subset containing the provided keys with values from the input data.
     *
     * @param  array|mixed  $keys
     * @return array
     */
    public function only($keys)

[j3j5]

Yes, that I understand, that's why I returned a PHPStan\Type\ArrayType in the first place. But looking at the source code of that class, I interpreted (wrongly it seems) that the constructor needed 2 arguments.

public function __construct(Type $keyType, Type $itemType)
{
	if ($keyType->describe(VerbosityLevel::value()) === '(int|string)') {
		$keyType = new MixedType();
	}
	$this->keyType = $keyType;
	$this->itemType = $itemType;
}

I looked at PHPStan's source code and I copypasted that one, thinking it made sense.

[j3j5]

LOL, this is what I was talking about https://travis-ci.org/nunomaduro/larastan/jobs/433160174#L650-L659

[j3j5]

I've pushed to the original branch, not sure how GH will handle now that the PR is already merged. Shall I submit another one?

[nunomaduro]

@j3j5 I think you can submit a new PR.