Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle redirect() and view() helper function #157

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

Korri
Copy link

@Korri Korri commented Oct 5, 2018

Fixes #68

@Korri Korri changed the title Handle "redirect()" helper function Handle redirect() and view() helper function Oct 5, 2018
@szepeviktor
Copy link
Collaborator

Thank you, it seems to be correct.

@szepeviktor szepeviktor merged commit 9ee700e into larastan:master Oct 5, 2018
@Korri Korri deleted the redirect-fix branch October 5, 2018 18:27
@nunomaduro
Copy link
Collaborator

Thanks @Korri for this! The version v0.3.2 has been tagged.

@barryvdh
Copy link

I still get this:

38     Method App\Http\Controllers\SomeController::index() should return
         Illuminate\Http\Response but returns Illuminate\View\View.    

6     Method App\Http\Controllers\HomeController::index() should return      
         Illuminate\Http\Response but returns Illuminate\Http\RedirectResponse.

Am I missing something? I'm on 0.3.12 with default config.

@nunomaduro
Copy link
Collaborator

@barryvdh Can you create a new issue with your exact code of the methods HomeController::index() and SomeController::index()?

@barryvdh
Copy link

Oh sorry, I see it already, the default typehint is wrong for the make:auth stub. https://github.com/laravel/framework/blob/af510b80fdf16ea1b6de908d9fdcc98687b9b4bd/src/Illuminate/Auth/Console/stubs/make/controllers/HomeController.stub
Created an issue there: laravel/framework#26830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants