Fixes relation create return type #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
|
Is it related to #208 ? |
|
@szepeviktor No, it's not related to that. This is just for calling |
|
@canvural Can you update this pull request? |
|
@nunomaduro Done 👍 |
|
Fell free to release a new version once you think it's appropriated. Don't forget, we should always discuss about major versions. That being said, the next version should be |
|
cc @canvural |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes the return type of
createmethod on relations. For example$user->accounts()->create()should return newly createdAccountmodel.The code makes a couple of assumptions. First of all, the model needs to define the property in the docblock of the class. laravel-ide-helper can write PHP docs for the models automatically. If a phpdoc does not exist for the given property, MixedType return type is used to avoid errors.
Secondly, I followed the convention from laravel-ide-helper so typehint should be either
Collection|ModelName[]orModelName. If it can't match it, MixedType is returned again.