Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine model return type after builder calls #336

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Determine model return type after builder calls #336

merged 1 commit into from
Oct 22, 2019

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Oct 21, 2019 •
edited by szepeviktor
Loading

This PR adds support for correctly determining the return type of code like this

User::with('foo')
    ->where('foo', 'bar')
    ->orWhere('bar', 'baz')
    ->firstOrFail();

@canvural canvural added the enhancement New feature or request label Oct 21, 2019
@nunomaduro nunomaduro merged commit 707658c into larastan:master Oct 22, 2019
@canvural canvural deleted the patch-1 branch October 22, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@canvural @nunomaduro