feat: adds support to laravel 7 & supports phpstan 12 #377
Conversation
|
Thanks @szepeviktor. Also added better testing against different laravel versions. |
nunomaduro
changed the title
|
I actually may turn this pull request into the next version of 0.5. That targets the next version of PHPStan. |
| "ext-json": "*" | ||
| }, | ||
| "require-dev": { | ||
| "orchestra/testbench": "^3.8", | ||
| "orchestra/testbench": "^3.6|dev-master", |
There was a problem hiding this comment.
No version of testbench will work properly yet, until orchestral/testbench-core#32 is merged.
A lot of stuff changed in 0.12 I actually have an incomplete branch that upgrades to 0.12 I can also push that if you want. |
| "illuminate/http": "5.6.*|5.7.*|5.8.*|^6.0", | ||
| "illuminate/pipeline": "5.6.*|5.7.*|5.8.*|^6.0", | ||
| "illuminate/support": "5.6.*|5.7.*|5.8.*|^6.0", | ||
| "illuminate/console": "5.6.*|5.7.*|5.8.*|^6.0|^7.0", |
There was a problem hiding this comment.
We can also drop support for 5.6 and 5.7 I think.
There was a problem hiding this comment.
😢
I guess it only gets harder for project supporting older versions:
https://github.com/rebing/graphql-laravel/blob/223642f36e444b931ba62e57a032ffa851f9b4fe/composer.json#L37-L38
I wonder though if it's possible, similar to phpstan shim, to have something alike for larastan.
|
@canvural can pull request your branch against this one? |
|
@nunomaduro Done. #378 |
|
I'd say only support for Laravel 6.0 LTS and 7.0 will be relevant in 2020. People using 5.x can just use the older version of larastan. |
nunomaduro
changed the title
|
PHPStan 0.12 is a breakthrough! |
|
@szepeviktor @canvural I will be running some tests here now, to see if everything works as expected 👍 |
This pull request prepares Larastan for Laravel 7.
Also, allows to start preparing Collision for Laravel 7. nunomaduro/collision#72
Closes #381