Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model scopes returns builder if scope return type is void #450

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix: model scopes returns builder if scope return type is void #450

merged 1 commit into from
Feb 5, 2020

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Feb 5, 2020

Fixes #448

If the return type of a local model scope is void, Larasan will return the builder.

@canvural canvural mentioned this pull request Feb 5, 2020
Closed
@canvural canvural changed the title fix: model scopes returns builder in any case fix: model scopes returns builder if scope return type is void Feb 5, 2020
@Gummibeer
Copy link

Thanks for adding it! ❤️

@canvural canvural merged commit 4fd788a into larastan:master Feb 5, 2020
@canvural canvural deleted the fix-void-scope-return branch February 5, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Result of void scope is used
3 participants
@canvural @Gummibeer @nunomaduro