feature:generic resources

[mr-feek]

resolves #437

I'm opening this up now to get feedback on if I am implementing correctly. I would appreciate some guidance as this is my first time working with generics and understanding what phpstan does behind the scenes.

Open Questions

• How do I implement getMethod and getProperty. Off the top of my head, I would think return $modelType->getMethod($methodName); however this requires a \PHPStan\Reflection\ClassMemberAccessAnswerer parameter, and I'm not sure what that is or how to resolve it.
• How do I test my extension correctly catches failing statements? IE I want to ensure $resource->foo() is caught as an error.

Improvements

• NOT POSSIBLE: Is there a way we can infer the type passed to a Resource without having to declare

/**
 * @extends JsonResource<User>
 */

At the top of resources? This is not ideal, and can hopefully be circumvented. I'm not sure how.

• Along with the above, ideally I would think $templateTypeMap = $classReflection->getActiveTemplateTypeMap(); would resolve the model type, rather than having to fetch it via the first parent...

[canvural]

Hi,

First, you can make sure $modelType is instance of ObjectType. If not you can return false. then you can use getClassReflection method to get the class reflection. Then you can use the hasMethod, getMethod etc. method on the reflection.

@extends JsonResource<User> doc block is required. All classes that extends a generic class should specify they are also generic by using this. You can read this article to have more knowledge of generics.

$classReflection->getActiveTemplateTypeMap(); should work. No need to reach to the parent. Why doesn't it work for you?

[mr-feek]

then you can use getClassReflection method to get the class reflection. Then you can use the hasMethod, getMethod etc. method on the reflection.

I see!! Thank you!

[mr-feek]

I believe I am now using getMethod and getProperty properly now, passing an OutOfClassScope instance

[mr-feek]

Although I haven't figured out how to solve

Along with the above, ideally I would think $templateTypeMap = $classReflection->getActiveTemplateTypeMap(); would resolve the model type, rather than having to fetch it via the first parent...`

The tests are passing so I'm going to open this up for review.

[mr-feek]

@canvural thank you for the review, feedback, and helping me learn about the workings of phpstan and generics.

Would you mind giving this another review please?

[canvural]

Looks good to merge. One last thing. Can you add this change to CHANGELOG under Unreleased?

[mr-feek]

done @canvural :)