fix: transform ide-helper relationship docblocks into typed collections #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-feek
force-pushed
the
collection-type-node-resolver-extension
branch
3 times, most recently
from
9b44987
to
542f7a4
Compare
szepeviktor
reviewed
Feb 27, 2020
src/Types/GenericEloquentCollectionTypeNodeResolverExtension.php
Outdated
Show resolved
Hide resolved
mr-feek
force-pushed
the
collection-type-node-resolver-extension
branch
from
542f7a4
to
ed9be1f
Compare
mr-feek
force-pushed
the
collection-type-node-resolver-extension
branch
from
ed9be1f
to
493aed9
Compare
canvural
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #476
This is almost entirely @ondrejmirtes's code. It seems to work well for us and fixes the broken test.