Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when migrations folder does not exist #498

Merged
merged 2 commits into from Mar 19, 2020

Conversation

deleugpn
Copy link
Contributor

With the recent update I'm getting a fatal error when the migrations folder doesn't exist:

Internal error: RecursiveDirectoryIterator::__construct(/var/task/database/migrations): failed to open dir: No such file or directory

This is an attempt to patch that up.

@canvural
Copy link
Collaborator

Thank you.

In the future we should make this configurable. Users should be able to specify the path in their phpstan.neon file, if they use different path.

@canvural canvural merged commit 6d3ce4d into larastan:master Mar 19, 2020
@deleugpn deleugpn deleted the patch-2 branch March 19, 2020 09:04
@deleugpn
Copy link
Contributor Author

Thanks @canvural. When making this configurable, please keep in mind that perhaps null should be a valid option. For me it wasn't about a different folder, but rather about not having laravel migrations in the project at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants