Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stubs for certain query builder methods #626

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fix stubs for certain query builder methods #626

merged 1 commit into from
Jul 28, 2020

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Jul 28, 2020 •
edited

whereBetween/orWhereBetween for the 2nd and whereRowValues/
orWhereRowValues for the 3rd arg also accept "array of values" and
not only key => values.

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

@mfn
Fix stubs for certain query builder methods
2b16c54 
`whereBetween`/`orWhereBetween` for the 2nd and `whereRowValues`/
`orWhereRowValues` for the 3rd arg also accept "array of values" and
not only key => values.

- Fixes #624
- Fixes #625
@mfn
Copy link
Contributor Author

mfn commented Jul 28, 2020

The StyleCI is unrelated, fixed via #627

This was referenced Jul 28, 2020
Closed
Closed
@szepeviktor szepeviktor merged commit ba092de into larastan:master Jul 28, 2020
@mfn mfn deleted the mfn-stubs branch July 28, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mfn @szepeviktor