Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return type of associate, dissociate and getChild methods of BelongsTo relations #633

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Aug 6, 2020

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

This PR fixes #631

@canvural
Copy link
Collaborator Author

canvural commented Aug 6, 2020

Hmm. The commit from StyleCI has skip ci So Travis did not run for this PR. We probably do not want that 😅

@canvural canvural changed the title fix: return type of associate, dissociate and getChild methods of BelongsTo relations fix: return type of associate, dissociate and getChild methods of BelongsTo relations Aug 6, 2020
@canvural canvural merged commit a3038a7 into master Aug 6, 2020
@canvural canvural deleted the patch-1 branch August 6, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative on BelongsTo::associate()
2 participants