Exclude test providers from autoloading #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add support for file method call on Request
Prevent loading classes used for testing only during analysis.
Use uniform directory names for tests based on RuleTest so they run on Windows.
szepeviktor
reviewed
Oct 22, 2020
szepeviktor
reviewed
Oct 22, 2020
|
Thank you very much @kwebble ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #683
Changes
Previously an instance of all detected service providers was created during analysis. This is changed. Now classes with namespaces defined in psr-4 paths in the autoload-dev configuration of
composer.jsonare skipped.Breaking changes
Since a number of classes previously autoloaded are skipped runtime behavior is changed. But I don't think it changes the outcome of the analysis.