Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model::with() accepts array of Closure #713

Merged

Conversation

kvas-damian
Copy link
Contributor

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Fixes #712

Changes

Ensures that if you call a Model::with() method with array of Closures it does not result in a false positive.

@canvural
Copy link
Collaborator

Looks good! Thank you @kvas-damian

@canvural canvural merged commit f1afe78 into larastan:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when passing array<string, Closure> to Model::with()
2 participants