Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for additional migration directories. #777

Merged
merged 6 commits into from
Feb 1, 2021

Conversation

haringsrob
Copy link
Contributor

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Fixes: #715

Changes

Add support for additional database migrations paths using additionalDatabaseMigrationPaths

Breaking changes

None, original parameter is left, only additional migrations paths can be defined (did not want to introduce multiple types for a single parameter string|array|null).

@szepeviktor
Copy link
Collaborator

Thank you!

Why not make databaseMigrationsPath accept a list?

@haringsrob
Copy link
Contributor Author

Did not want to introduce multiple types for a single parameter string|array|null.

But if it is ok, then I can of course reuse that parameter.

@canvural
Copy link
Collaborator

canvural commented Feb 1, 2021

Hi,

Thank you for this!

I think we can just convert databaseMigrationsPath to list. Then we can release it as 0.7.x 👍

@szepeviktor
Copy link
Collaborator

szepeviktor commented Feb 1, 2021

Everything is so 🍏 What to do now???

Thank you for your contribution!

@szepeviktor szepeviktor merged commit c4382ae into larastan:master Feb 1, 2021
@haringsrob
Copy link
Contributor Author

👍 Thanks for being responsive!

@canvural
Copy link
Collaborator

canvural commented Feb 1, 2021

Thank you!

I'll upgrade the UPGRADE.md file, and make a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple databaseMigrationsPath
3 participants