Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .github folder to the export-ignore list #849

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Add .github folder to the export-ignore list #849

merged 1 commit into from
Jun 20, 2021

Conversation

dingo-d
Copy link
Contributor

@dingo-d dingo-d commented Jun 20, 2021

  • Added or updated tests (no tests needed)
  • Documented user facing changes (no user facing changes, just a slimmer release)
  • Updated CHANGELOG.md

Changes

Added .github folder to the .gitattributes so that it's not copied over when people require the package.

No breaking changes. Not sure if I need to update the changelog or if this will be done when a new release is made πŸ€·πŸΌβ€β™‚οΈ

@szepeviktor
Copy link
Collaborator

Sparing 1 KB, Denis!

@szepeviktor szepeviktor merged commit 8d192e2 into larastan:master Jun 20, 2021
@dingo-d
Copy link
Contributor Author

dingo-d commented Jun 20, 2021

Seeing how this package has (currently) 4 086 874 installs, I'd say it adds up πŸ˜‰

@williamdes
Copy link

Very good contribution !

You could also remove phpstan.neon.dist ;)

@dingo-d
Copy link
Contributor Author

dingo-d commented Jul 1, 2021

Ufff forgot about that one. Can you make a PR? I can do it, not a big problem, but since you've noticed it πŸ˜„

@williamdes
Copy link

Ufff forgot about that one. Can you make a PR? I can do it, not a big problem, but since you've noticed it πŸ˜„

Go ahead you will be quicker than me πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants