Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting dateClass #865

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix getting dateClass #865

merged 1 commit into from
Jul 5, 2021

Conversation

szepeviktor
Copy link
Collaborator

Fixes #864

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

@szepeviktor szepeviktor requested a review from canvural July 5, 2021 09:57
@szepeviktor
Copy link
Collaborator Author

@canvural Could you come up with a test?

@canvural
Copy link
Collaborator

canvural commented Jul 5, 2021

@szepeviktor Yeah I think so. I'll add it.

@canvural canvural merged commit c1419da into master Jul 5, 2021
@canvural canvural deleted the szepeviktor-patch-1 branch July 5, 2021 10:12
@canvural
Copy link
Collaborator

canvural commented Jul 5, 2021 •
edited
Loading

Ok, I can't come up with a test case. Anyway we now know we shouldn't access that property directly 😄

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canvural canvural canvural approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected token "|", expected type at offset 0
2 participants
@szepeviktor @canvural