Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for orWhere HigherOrderBuilderProxy property #884

Merged
merged 1 commit into from
Jul 19, 2021
Merged

feat: support for orWhere HigherOrderBuilderProxy property #884

merged 1 commit into from
Jul 19, 2021

Conversation

shaffe-fr
Copy link
Contributor

@shaffe-fr shaffe-fr commented Jul 19, 2021 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes: not relevant
  • Updated CHANGELOG.md

Changes

HigherOrderBuilderProxy property orWhere is not supported by Larastan yet.

Closes #885

@shaffe-fr shaffe-fr mentioned this pull request Jul 19, 2021
Closed
@szepeviktor
Copy link
Collaborator

Very good-looking PR!

@shaffe-fr shaffe-fr force-pushed the fix/orwhere-property branch 2 times, most recently from 2cd3a6d to 366ea3d Compare July 19, 2021 13:14
@shaffe-fr shaffe-fr marked this pull request as ready for review July 19, 2021 13:21
@shaffe-fr
Copy link
Contributor Author

The PR is ready to be reviewed.
I don't think the failing tests are related to this PR.
Thanks!

canvural
canvural requested changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@canvural canvural left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I just added one small correction review.

Indeed the errors seems not related to this PR. After you fix the review we can merge this.

CHANGELOG.md Outdated Show resolved Hide resolved
@shaffe-fr
Copy link
Contributor Author

My mistake, it's moved!

@canvural canvural changed the title Support for orWhere HigherOrderBuilderProxy property feat: support for orWhere HigherOrderBuilderProxy property Jul 19, 2021
@canvural canvural merged commit 72aa0af into larastan:master Jul 19, 2021
@canvural
Copy link
Collaborator

Thank you!

@shaffe-fr shaffe-fr deleted the fix/orwhere-property branch July 19, 2021 16:26
@shaffe-fr
Copy link
Contributor Author

Sorry I forgot to change the commit message....

@szepeviktor
Copy link
Collaborator

@canvural Any idea on failing CI?

@canvural
Copy link
Collaborator

@canvural Any idea on failing CI?

No. I didn't check it in detail yet. But a lot of stuff changed in 9.x

Is it possible to tell Github Actions a workflow is allowed to fail? 9.x is still 6 months away and things can break anytime.

@szepeviktor
Copy link
Collaborator

a workflow is allowed to fail

This is a highly requested feature of GHA 😢

@szepeviktor szepeviktor mentioned this pull request Jul 19, 2021
Merged
@ganyicz ganyicz mentioned this pull request May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canvural canvural canvural requested changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magic orWhere HigherOrderBuilderProxy not supported
3 participants
@shaffe-fr @szepeviktor @canvural