Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile method on class Runner should be public? #485

Open
arjunguha opened this issue Apr 17, 2021 · 0 comments
Open

compile method on class Runner should be public? #485

arjunguha opened this issue Apr 17, 2021 · 0 comments
Assignees

Comments

@arjunguha
Copy link
Member

@jpolitz you made this commit:

e59d968

Are you still relying on these functions? They are not public (i.e., not declared in the interface). Of course, nothing is really private in JS or TS.

I ask because I've encountered a situation where babylon's parser can throw an exception in certain weird cases. It may not be an issue for you, but wanted to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants