New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file/folder sharing feature #37
Conversation
@raghav-dalmia please remove the merge conflict. |
Done @nurdtechie98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've tested this locally.
@raghav-dalmia Great work. Overall looks good to me, just some minor changes. As soon as you make the changes. I'll merge this one. Thanks for your time :)
Done @inishchith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raghav-dalmia other than changes said by @inishchith, make sure you code is pep8 compliant, cos I see a lot of errors on running flake8 test. Rest looks good to me.
I fix my code using autopep8, please check. Sorry about this thing. |
@raghav-dalmia can you please sync your branch. As i see you've changes which are irrelevant to the task. |
Sorry I forgot to update my local repo, that's why this happened. Now, I think it is perfect. Please review. |
@raghav-dalmia still has some warnings in flake8 test: ./drive_cli/actions.py:298:25: W291 trailing whitespace
./drive_cli/actions.py:299:35: W291 trailing whitespace
./drive_cli/actions.py:305:33: W291 trailing whitespace
./drive_cli/actions.py:308:53: W291 trailing whitespace
./drive_cli/actions.py:319:79: W291 trailing whitespace |
Now it's fine. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raghav-dalmia good job, LGTM merging.
closes #15 |
I write a function a function name
share()
inaction.py
, which takefile id
as mandatory argument androle
,type
andmessage
are it's optional arguments.Following image show result of
drive share --help
If
type
isanyone
, it will generate a share link and print it, otherwise, it will take email id as an argument and share the link directly to grantee/user.@inishchith @nurdtechie98, please review.
Fixes #15