Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtests assertion error #17

Open
jamessspanggg opened this issue Feb 7, 2019 · 2 comments
Open

systemtests assertion error #17

jamessspanggg opened this issue Feb 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jamessspanggg
Copy link

Hello,

I ran systemtests in AB4 and obtained 3 assertion errors similar to this:
screen shot 2019-02-07 at 11 14 45 pm

These errors also caused Travis to fail its build.

After that, I changed the variable SEARCH_PAGE_URL to the following:
screen shot 2019-02-07 at 11 35 11 pm

Now systemtests works fine and Travis' build passed as well.

Hope this helps anyone who had the same issue!

Regards,
James

@okkhoy
Copy link
Collaborator

okkhoy commented Feb 9, 2019

@jamessspanggg Thanks for the update! We are fixing this issue in the module fork of AB-4.
You can sync the changes from the upstream repo (this semester fork of AB-4).

@okkhoy okkhoy added the bug Something isn't working label Feb 9, 2019
@okkhoy
Copy link
Collaborator

okkhoy commented Feb 10, 2019

FIxed in: nus-cs2103-AY1819S2/addressbook-level4@231b72b
You can either sync changes from the module fork of AB-4 or make the necessary minor edit in your organization fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants