PR review

[li-s]

Hello guys, I have a quick question.

If reviewing PR, and the code has multiples of the same mistake (eg. wrong indent for multiple files), do we flag every single mistake, or just flag one? I'm thinking that if you flag every mistake, it will just make the other member angry at why you are focusing on such minor mistakes.

Any thoughts on this?

[damithc]

Good observation @li-s . The points in the following link sort of touches on that situation. Have a look and post here if you have further doubts.

[li-s]

So for each coding violation that is the same, I should just write "I noticed this issue as well"? It seems like it will clog the comments section.

[peter-yeh]

Hi @damithc , I have this issue as well, when the repo I am reviewing also commits many of the same mistake. After reading the Best practices for reviewing PRs, I still did not find the answer I am looking for.

[damithc]

So for each coding violation that is the same, I should just write "I noticed this issue as well"? It seems like it will clog the comments section.

Hmm... that's not what the guide recommends, right?

For example, adding this comment in one place is enough. Let the author finds the other places by him/herself.

This line seems to exceed the recommended max line length. I noticed the same problem in a few other places too.

[li-s]

Ok thanks, so I just wite that line.