Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep part of code that prints output in terminal after JavaFX? #136

Closed
erisjacey opened this issue Aug 31, 2020 · 2 comments
Closed

Keep part of code that prints output in terminal after JavaFX? #136

erisjacey opened this issue Aug 31, 2020 · 2 comments

Comments

@erisjacey
Copy link

erisjacey commented Aug 31, 2020

I'm not sure whether this is a discussion worth having, but I have this small query:

I have integrated JavaFX into my project and now have a fully functional (albeit ugly-looking) GUI. I'm assuming this is the main platform users will be interacting on/with.

Does that mean the part of the code that deals with printing output onto the terminal (i.e. how we've been interacting with the user prior) is now rendered obsolete? Should I remove it to prevent unncessary bloat in my code?

The only purpose I see in keeping it right now is the fact that if I remove it, it'd be hard to do semi-automated testing using the provided .bat/.sh file, but I think unit testing using JUnit seems far more efficient as a form of automated testing.

Could anyone shed some light on this? Any comments would be appreciated!

@damithc
Copy link
Contributor

damithc commented Aug 31, 2020

From iP requirements POV, there is no need to keep the CLI but you are welcome to keep it if you think the benefits outweigh the costs.

@erisjacey
Copy link
Author

Thanks prof!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants