Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When should we write javadoc? #206

Closed
WeiJie96 opened this issue Sep 12, 2020 · 2 comments
Closed

When should we write javadoc? #206

WeiJie96 opened this issue Sep 12, 2020 · 2 comments

Comments

@WeiJie96
Copy link

Should we write javadoc for obvious methods? E.g. getters/setters, one/two-liners that just prints out a string
Should we write javadoc for all non-private (includes package, protected, public) methods and classes, or just the public ones?

@damithc
Copy link
Contributor

damithc commented Sep 13, 2020

General rule:

  • If specified in the coding standard, follow it strictly. No deviations.
  • If not specified in the coding standard, you can make your own decision but it should be applied consistently i.e., the whole team needs to agree and follow. Some options you can use here:
    • Follow what the current code seems to be following implicitly
    • Follow what's specified by one of the more detailed coding standards cited by our own coding standard (see the references section)

@WeiJie96
Copy link
Author

Thank you for the detailed explanation, Prof Damith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants