Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is adding the new keyword to calls to constructors in sequence diagrams considered a bug #321

Closed
samuelfangjw opened this issue Apr 17, 2021 · 2 comments

Comments

@samuelfangjw
Copy link

With reference to issue #707 and the image above, the tester agues that using the new keyword in calls to constructor is inaccurate and the new keyword should be omitted from the sequence diagram e.g. CommandResult(..., uiCommand) instead of new CommandResult(..., uiCommand). The tester has assigned this as a medium severity bug.

Is not omitting the new keyword considered a bug and is this part of the module's UML standard? I would argue that there is no loss of information and a reader's understanding is not hindered by the new keyword and therefore not a bug. However, I also think it would be reasonable to accept this bug (at a lower severity level) if this was part of the module's UML standard as some examples in the textbook do omit it, although I am unable to find a definitive source for this in the textbook.

@damithc
Copy link
Contributor

damithc commented Apr 17, 2021

I think there is no reason for new to be there. But you are right, it doesn't cause much harm. Would be fine to accept as severity.VeryLow bug.

@samuelfangjw
Copy link
Author

Ok thanks prof!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants