Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query web should make all links absolute #12583

Open
adamnemecek opened this issue Apr 19, 2024 · 1 comment
Open

query web should make all links absolute #12583

adamnemecek opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request needs-triage An issue that hasn't had any proper look networking All about our `http` and `url` commands and everything going accross the network.

Comments

@adamnemecek
Copy link

Related problem

Currently, query web returns links are they are on the website, if they are relative, they are returned relative. I believe that the desired behavior is to return links in the absolute form.

This is the behavior of for example Chrome. In the JS console $$('a[href$=pdf]').map(x => x.href) will return links in the absolute form even if they are relative.

Describe the solution you'd like

Links should be returned in absolute form. Possibly, there could be a --raw option that will return links in the form as it is on the site.

Describe alternatives you've considered

Users would be making links absolute themselves. I don't think anyone ever wants relative links.

Additional context and details

No response

@adamnemecek adamnemecek added enhancement New feature or request needs-triage An issue that hasn't had any proper look labels Apr 19, 2024
@sholderbach sholderbach added the networking All about our `http` and `url` commands and everything going accross the network. label Apr 19, 2024
@BaerLKR
Copy link

BaerLKR commented May 16, 2024

The problem is that the original url that was requested by http get is not passed through to the query-plugin, so I don't know how one would complete the relative links.
But I could very well be wrong since this is my first try at contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage An issue that hasn't had any proper look networking All about our `http` and `url` commands and everything going accross the network.
Projects
None yet
Development

No branches or pull requests

3 participants