glob command doesn't accept glob argument type

[dedebenui]

Describe the bug

The glob command doesn't accept arguments that have been converted with into glob

How to reproduce

let pattern = [Desktop *] | path join | into glob
glob $pattern

I get the following error:

Error: nu::shell::cant_convert

  × Can't convert to string.
   ╭─[entry #8:2:6]
 1 │ let pattern = [Desktop *] | path join | into glob
 2 │ glob $pattern
   ·      ────┬───
   ·          ╰── can't convert glob to string
   ╰────

Expected behavior

I expect the same output as glob Desktop/*

╭───┬───────────────────────────╮
│ 0 │ /Users/john/Desktop/file1 │
│ 1 │ /Users/john/Desktop/file2 │
│ 2 │ /Users/john/Desktop/file3 │
╰───┴───────────────────────────╯

Screenshots

No response

Configuration

key	value
version	0.93.0
major	0
minor	93
patch	0
branch	main
commit_hash	cb6d495
build_os	macos-aarch64
build_target	aarch64-apple-darwin
rust_version	rustc 1.77.2 (25ef9e3d8 2024-04-09)
rust_channel	1.77.2-aarch64-apple-darwin
cargo_version	cargo 1.77.2 (e52e36006 2024-03-26)
build_time	2024-05-01 08:27:15 +02:00
build_rust_channel	debug
allocator	mimalloc
features	default, sqlite, system-clipboard, trash, which
installed_plugins

Additional context

The bug is not present with ls:

> let pattern = [Desktop *] | path join | into glob
> ls $pattern
╭───┬───────────────┬──────┬───────────┬────────────╮
│ # │      name     │ type │   size    │  modified  │
├───┼───────────────┼──────┼───────────┼────────────┤
│ 0 │ Desktop/file1 │ file │ 213.3 KiB │ 2 days ago │
│ 1 │ Desktop/file2 │ file │  45.5 KiB │ a week ago │
│ 2 │ Desktop/file3 │ file │  45.5 KiB │ a week ago │
╰───┴───────────────┴──────┴───────────┴────────────╯

[fdncred]

Right, the glob command wants a string pattern, not a glob, and then it does its own globbing. The glob command uses a completely different globbing crate than anything else in nushell.

For your example, this should work, since it's asking for a string.

let pattern = [Desktop *] | path join
glob $pattern

[FulecoRafa]

Hello, first time contributing and I would like to work on this issue

[equt]

Maybe we could first update the doc to reflect this, as the doc currently states this as an example to show the glob type is the first class object.

[fdncred]

Maybe we could first update the doc to reflect this, as the doc currently states this as an example to show the glob type is the first class object.

Agreed. That should be ls $g instead of glob $g.