Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from fods #9507

Open
double-daruma opened this issue Jun 22, 2023 · 3 comments
Open

from fods #9507

double-daruma opened this issue Jun 22, 2023 · 3 comments
Labels
enhancement New feature or request file-format Parsing/Writing of file formats/protocols upstream problem with upstream dependency

Comments

@double-daruma
Copy link

Related problem

from ods is already supported. it would me nice if flat, non compressed ods files would also be supported.

Describe the solution you'd like

A from fods command or make from ods accept non compressed ods files or have a flat for from ods

Describe alternatives you've considered

No response

Additional context and details

No response

@double-daruma double-daruma added enhancement New feature or request needs-triage An issue that hasn't had any proper look labels Jun 22, 2023
@fdncred
Copy link
Collaborator

fdncred commented Jun 22, 2023

i've never seen one. what do they look like?

@Taywee
Copy link
Contributor

Taywee commented Jun 23, 2023

ODS is a zip file of mostly XML files.

FODS (Officially "OpenDocument Spreadsheet Flat XML") is a single uncompressed unarchived XML file representing the same data in mostly the same format. All binary data is embedded, and all documents are compiled into a single one.

I use this sometimes for spreadsheets that I version control with Git and regularly update. The diffs aren't pretty, but they're a bit better than binary blobs.

@sholderbach
Copy link
Member

Thanks for the explainer @Taywee

For our Excel/ODS loading we use the calamine crate. The main entry point we use to parse ods directly includes the zip unpacking step. I think they have a lot of the code that would be needed for the XML parsing internally. So if you want to have this functionality @double-daruma I think it would be best to raise it with them to add an entry point that implements the FODS spec and reuses the general ODS parsing.

On the nushell side of things, the question for the rarer file types will always be: Should this be included out of the box or should this be a plugin. But as the heavy weight of the whole spreadsheet format parsing is done by one crate this favors keeping all of them together in my view.

@sholderbach sholderbach added upstream problem with upstream dependency file-format Parsing/Writing of file formats/protocols and removed needs-triage An issue that hasn't had any proper look labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request file-format Parsing/Writing of file formats/protocols upstream problem with upstream dependency
Projects
None yet
Development

No branches or pull requests

4 participants