Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After ExecuteHostCommand is handled, new prompt is rendered #755

Closed
kit494way opened this issue Feb 18, 2024 · 1 comment · Fixed by #758 or #770
Closed

After ExecuteHostCommand is handled, new prompt is rendered #755

kit494way opened this issue Feb 18, 2024 · 1 comment · Fixed by #758 or #770
Labels
bug Something isn't working

Comments

@kit494way
Copy link
Contributor

Platform Windows 11 WSL2 Ubuntu 20.04,
Terminal software wsltty 3.5.1

Describe the problem you are observing.

Steps to reproduce

❯ def do_nothing [] {}
❯ let x = {name: do_nothing, modifier: control, keycode: char_g, mode: [vi_normal, vi_insert], event: {send: executehostcommand, cmd: 'do_nothing'}}
❯ $env.config.keybindings = ($env.config.keybindings | append $x)
❯ # type C-g here, then new prompt is rendered
@kit494way kit494way added the bug Something isn't working label Feb 18, 2024
@fdncred
Copy link
Collaborator

fdncred commented Feb 18, 2024

I had to add emacs to mode: but yes, it does draw a new prompt.

I wonder if that's because it's just like "hitting enter" somehow? I haven't looked into it in a while so I don't remember. I have quite a few keybindings that use executehostcommand. It would be good to not render a new prompt if we don't have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants