Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable physics lists #23

Closed
cathalsweeney opened this issue Jul 3, 2023 · 11 comments
Closed

Configurable physics lists #23

cathalsweeney opened this issue Jul 3, 2023 · 11 comments

Comments

@cathalsweeney
Copy link
Contributor

The geant4 physics lists are hardcoded in PredictionBase/G4CascadePhysicsList.cc. It would be nice to be able to configure the physics list using a fcl. This would feed through to not only G4Cascade, but also G4CrossSection, G4Reweighter, and a couple of other places

@admlw
Copy link

admlw commented Jul 3, 2023

To add some more context here - for NOvA right now we're investigating using an alternate EM physics lists (EMZ from G4EmStandardPhysics_option4) and we'll want to run G4Reweight for that - right now G4EmStandardPhysics is setup by default.

@calcuttj
Copy link
Collaborator

calcuttj commented Sep 1, 2023

Sorry I haven't seen this yet. I'll try this out today and I'll ask for a release soon

@calcuttj
Copy link
Collaborator

calcuttj commented Sep 1, 2023

By the way, if you have any more suggestions on functionality please let me know -- and if I don't respond promptly feel free to send an email :)

@calcuttj
Copy link
Collaborator

calcuttj commented Sep 1, 2023

Started working on this branch. Will have to flesh out some more stuff to make it configurable. Would one of you be willing to test when it's ready?

@cathalsweeney
Copy link
Contributor Author

I'm taking a look at this in a local build of geant4reweight. If I have the necessary permissions I'll push any changes I make to the feature branch you're working on. Looks like the remaining work is mostly just adding in a new fhicl parameter in G4Cascade.cc etc.

@cathalsweeney
Copy link
Contributor Author

The configurable physics lists seems to work for me in some local tests! I've created a pull request which just allows the configuring to be done for G4Cascade etc. :
#25

Might be worth an new official build of Geant4Reweight with this new feature?

@cathalsweeney
Copy link
Contributor Author

Hi @lgarren (please redirect me if necessary). NOvA would like a release with the new features introduced via feature/calcuttj_configurable_physlist (which are already available in the latest LArSoft release). What is the best way to go about this?

Despite what a pull request between branches suggests, I think there are only 11 files that we actually want changes in. I am happy to try do some surgery to introduce the necessary changes into the NOvA branch, but am worried that the history will become messy.

@lgarren
Copy link
Contributor

lgarren commented Nov 20, 2023

@cathalsweeney Would you work with @calcuttj to make a PR for the nova_v01_16_br branch?

@cathalsweeney
Copy link
Contributor Author

Yes I will get to work on that, and I'll loop Jake in when necessary. Thanks Lynn

@cathalsweeney
Copy link
Contributor Author

Hi @lgarren , a pull request has been merged into nova_v01_16_br, and the version number has been bumped in CMakeLists.txt

@lgarren
Copy link
Contributor

lgarren commented Nov 21, 2023

The nu v3_13_04h distribution is now available on SciSoft with geant4reweight v01_16_05.

@lgarren lgarren closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants