-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable physics lists #23
Comments
To add some more context here - for NOvA right now we're investigating using an alternate EM physics lists (EMZ from G4EmStandardPhysics_option4) and we'll want to run G4Reweight for that - right now |
Sorry I haven't seen this yet. I'll try this out today and I'll ask for a release soon |
By the way, if you have any more suggestions on functionality please let me know -- and if I don't respond promptly feel free to send an email :) |
Started working on this branch. Will have to flesh out some more stuff to make it configurable. Would one of you be willing to test when it's ready? |
I'm taking a look at this in a local build of geant4reweight. If I have the necessary permissions I'll push any changes I make to the feature branch you're working on. Looks like the remaining work is mostly just adding in a new fhicl parameter in G4Cascade.cc etc. |
The configurable physics lists seems to work for me in some local tests! I've created a pull request which just allows the configuring to be done for G4Cascade etc. : Might be worth an new official build of Geant4Reweight with this new feature? |
Hi @lgarren (please redirect me if necessary). NOvA would like a release with the new features introduced via feature/calcuttj_configurable_physlist (which are already available in the latest LArSoft release). What is the best way to go about this? Despite what a pull request between branches suggests, I think there are only 11 files that we actually want changes in. I am happy to try do some surgery to introduce the necessary changes into the NOvA branch, but am worried that the history will become messy. |
@cathalsweeney Would you work with @calcuttj to make a PR for the nova_v01_16_br branch? |
Yes I will get to work on that, and I'll loop Jake in when necessary. Thanks Lynn |
Hi @lgarren , a pull request has been merged into nova_v01_16_br, and the version number has been bumped in CMakeLists.txt |
The nu v3_13_04h distribution is now available on SciSoft with geant4reweight v01_16_05. |
The geant4 physics lists are hardcoded in
PredictionBase/G4CascadePhysicsList.cc
. It would be nice to be able to configure the physics list using a fcl. This would feed through to not only G4Cascade, but also G4CrossSection, G4Reweighter, and a couple of other placesThe text was updated successfully, but these errors were encountered: