New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on binary strings #14

Open

xzfc opened this issue Oct 23, 2021 · 1 comment

Labels

bug

xzfc commented Oct 23, 2021

The following snippets crash nsh:

Invalid UTF-8 in the command substitution output: $(printf '\xff').
Invalid UTF-8 in env vars: (run from bash) A=$'\xff' ./target/release/nsh.
Null byte in command arguments: true $(printf '\x00').

Possible fix to 1 and 2: store strings in Vec<u8>, OsString, or bstr rather than String which forces strings to be valid UTF-8.

Proper behavior for 3 is not specified for POSIX sh; other shells treat it differently.

The text was updated successfully, but these errors were encountered:

nuta added the bug label

Owner

nuta commented Oct 24, 2021

Good catch and thanks for detailed explanation! I'll work on it when I have time :)

s3i7h mentioned this issue

Multibyte (and/or double width) character problem #34

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment