Fix unit tests failing with Numpy 1.24.0 (#759)

With the release of Numpy 1.24 on December 18, certain unit tests started failing in Github actions due to lack of accuracy. Unfortunately the issue cannot be reproduced locally, and as such is impossible to debug. Out of caution, this PR excludes Numpy version 1.24 from the dependency range until we have more clarity about the situation.

.github/workflows/test.yaml

@@ -96,7 +96,7 @@ jobs:
           python -um pip install "$_wheel[import_gmsh]"
       - name: Install Scipy
         if: ${{ matrix.matrix-backend == 'scipy' }}
-        run: python -um pip install --upgrade --upgrade-strategy eager scipy
+        run: python -um pip install --upgrade scipy
       - name: Configure MKL
         if: ${{ matrix.matrix-backend == 'mkl' }}
         run: |

nutils/numeric.py

@@ -243,7 +243,7 @@ def inv(A):
 
 isarray = lambda a: isinstance(a, numpy.ndarray)
 isboolarray = lambda a: isarray(a) and a.dtype == bool
-isbool = lambda a: isboolarray(a) and a.ndim == 0 or type(a) == bool
+isbool = lambda a: isboolarray(a) and a.ndim == 0 or isinstance(a, (bool, numpy.bool_))
 isint = lambda a: isinstance(a, numbers.Integral)
 isnumber = lambda a: isinstance(a, numbers.Number)
 isintarray = lambda a: isarray(a) and numpy.issubdtype(a.dtype, numpy.integer)

pyproject.toml

@@ -8,7 +8,7 @@ requires-python = '~=3.7'
 dependencies = [
     "appdirs~=1.0",
     "bottombar~=2.0.2",
-    "numpy>=1.17",
+    "numpy>=1.17,<1.24",
     "psutil~=5.0",
     "stringly",
     "treelog>=1.0b5",

tests/test_numeric.py

@@ -160,7 +160,7 @@ def test_isint(self):
 
     def test_isbool(self):
         self.assertTrue(numeric.isbool(True))
-        self.assertTrue(numeric.isbool(numpy.bool(True)))
+        self.assertTrue(numeric.isbool(numpy.bool_(True)))
         self.assertTrue(numeric.isbool(numpy.array(True)))
         self.assertFalse(numeric.isbool(numpy.array([True])))