Skip to content
This repository has been archived by the owner on Oct 3, 2022. It is now read-only.

Rewrite for better handling of services that have gone down #46

Merged
merged 13 commits into from Mar 24, 2020

Conversation

woutslakhorst
Copy link
Member

Lessons learnt from chaos testing!

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #46 into master will increase coverage by 2.15%.
The diff coverage is 82.63%.

Impacted Files Coverage Δ Complexity Δ
...n/nl/nuts/consent/bridge/corda/StateFileStorage.kt 91.30% <ø> (ø) 6.00 <0.00> (?)
.../nuts/consent/bridge/nats/NatsManagedConnection.kt 66.66% <66.66%> (ø) 9.00 <9.00> (?)
.../consent/bridge/diagnostics/NatsHealthIndicator.kt 71.42% <71.42%> (ø) 2.00 <2.00> (?)
...uts/consent/bridge/corda/CordaManagedConnection.kt 75.71% <75.71%> (ø) 11.00 <11.00> (?)
...idge/pipelines/ConsentStateChangeToNatsPipeline.kt 78.26% <78.26%> (ø) 6.00 <6.00> (?)
...ridge/pipelines/CordaStateMachineToNatsPipeline.kt 81.13% <81.13%> (ø) 14.00 <14.00> (?)
...nt/bridge/diagnostics/CordaFlowHealthIndicators.kt 84.44% <81.25%> (-9.68%) 0.00 <0.00> (ø)
...bridge/pipelines/CordaStateChangeToNatsPipeline.kt 81.66% <81.66%> (ø) 26.00 <26.00> (?)
...nsent/bridge/corda/CordaManagedonnectionFactory.kt 87.50% <87.50%> (ø) 0.00 <0.00> (?)
...onsent/bridge/nats/NatsManagedConnectionFactory.kt 87.50% <87.50%> (ø) 5.00 <5.00> (?)
... and 21 more

@woutslakhorst woutslakhorst marked this pull request as ready for review March 20, 2020 16:23
@woutslakhorst woutslakhorst added this to In progress in v0.13.0 via automation Mar 23, 2020
})
update.result.doOnSuccess(Consumer {
// update event to suc6 status
// event.name = EventName.EventConsentRequestFlowSuccess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That event was removed from the state diagram, it was a dead-end state. Is always overridien by another state.

@woutslakhorst woutslakhorst merged commit a0e528a into master Mar 24, 2020
v0.13.0 automation moved this from In progress to Done Mar 24, 2020
@woutslakhorst woutslakhorst deleted the rewrite branch March 24, 2020 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
v0.13.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants