Skip to content
Browse files
feat: add support for logging out without an API endpoint (#124)
This is a fix for

Setting the `logout` strategy to `false` will effectively mean that
logout does nothing (it simple returns).

However, when you have a stateless API, and no need to call
a logout endpoint, you still want the user to be logged out
in the browser (token removed, session reset, that sort of stuff).

This change handles that by not returning if the logout option
is falsy, but instead only skipping over the networking part.

I think this is the behaviour people would expect when they set
logout to `false`.
  • Loading branch information
joostdecock authored and pi0 committed Apr 6, 2018
1 parent 554a042 commit 6189c6d3f7616889aaec4a002752359296d623a0
Showing 1 changed file with 6 additions and 6 deletions.
@@ -73,14 +73,14 @@ export default class LocalScheme {

async logout (endpoint) {
if (!this.options.endpoints.logout) {
// Only connect to logout endpoint if it's configured
if (this.options.endpoints.logout) {
await this.$auth
.requestWith(, endpoint, this.options.endpoints.logout)
.catch(() => { })

await this.$auth
.requestWith(, endpoint, this.options.endpoints.logout)
.catch(() => { })

// But logout locally regardless
if (this.options.tokenRequired) {

0 comments on commit 6189c6d

Please sign in to comment.