fix: check if cookies is an array #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this needed? |
|
Because cookies can be a string and unshift accepts only array |
|
I mean at a higher level: When is it a string? When is it an array? Why? |
|
Hello @bmulholland we get a string value from the SSR side We don't really know why from our side it is a string and no have time to investigate more. @pi0 you don't agree with this fix ? Regards, Gaetan |
|
Thanks for the additional detail and the link. Looks like this is an untyped return value, and I think it happens when there's only one cookie to set (instead of multiple cookies). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.