Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default auth0 audience #239

Merged
merged 2 commits into from Sep 10, 2018
Merged

remove default auth0 audience #239

merged 2 commits into from Sep 10, 2018

Conversation

kazazes
Copy link
Contributor

@kazazes kazazes commented Sep 9, 2018

As of June 8th, the jwt-bearer grant isn't available to new Auth0 applications. Therefore, any new app (or OIDC compliant app) cannot get a token without a specified audience (#176). This is a breaking change from Auth0's end.

In #222, this was fixed, but a default audience was added in an attempt to preserve backwards compatibility. @ishitatsuyuki pointed out that the default is the incorrect value and the correct value cannot be determined from existing options. This reverts the default inclusion while keeping the fix, and updates the docs to specify when audience is required in the auth0 strategy.

As of June 8th, the jwt-bearer grant isn't available to new applications. Therefore, any new app cannot get a token without a specified audience (#176). This is a breaking change from upstream.

The audience *must* match the API's audience. However, audience can be omited if a default audience is specified in the tenent's settings. https://auth0.com/docs/tokens/id-token#validate-the-claims
Copy link
Contributor

@ishitatsuyuki ishitatsuyuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@pi0
Copy link
Member

pi0 commented Sep 10, 2018

@ishitatsuyuki Thanks for your patience review and your good feedbacks.

@kazazes Thanks for your contributions.

I love community ❤️

@pi0 pi0 merged commit abfa084 into nuxt-community:dev Sep 10, 2018
@manniL
Copy link
Member

manniL commented Nov 7, 2018

@pi0 This fix isn't included in the master branch by now (and therefore in no release)

@lykkechen
Copy link

lykkechen commented Dec 7, 2018

@pi0 This fix isn't included in the master branch by now (and therefore in no release)

When will this fix be published on npm?

@nicbavetta
Copy link

@pi0 This fix isn't included in the master branch by now (and therefore in no release)

When will this fix be published on npm?

I am wondering the same.

Until the "audience" fix is pushed to master, we cannot obtain JWT access tokens from Auth0 through the Auth Module. Is there anything we can do to expedite the merge process? Would be happy to help.

@lykkechen
Copy link

lykkechen commented Mar 28, 2019

@pi0 This fix isn't included in the master branch by now (and therefore in no release)

When will this fix be published on npm?

I am wondering the same.

Until the "audience" fix is pushed to master, we cannot obtain JWT access tokens from Auth0 through the Auth Module. Is there anything we can do to expedite the merge process? Would be happy to help.

@nicbavetta There is a workaround to setting the audience directly in the code, you can set it in the Tenants Settinng in Auth Dashboard Setting a default audience, there an API Authorization Settings section

@nicbavetta
Copy link

@pi0 This fix isn't included in the master branch by now (and therefore in no release)

When will this fix be published on npm?

I am wondering the same.
Until the "audience" fix is pushed to master, we cannot obtain JWT access tokens from Auth0 through the Auth Module. Is there anything we can do to expedite the merge process? Would be happy to help.

@nicbavetta There is a workaround to setting the audience directly in the code, you can set it in the Tenants Settinng in Auth Dashboard Setting a default audience, there an API Authorization Settings section

Thanks for pointing this out. I do now have the JWT after setting the default audience in Auth0. This will work for now, however, do hope to see the AuthModule code make its way into production at some point :)

@FacioRatio
Copy link

Any update when this will get merged into master?

@pi0
Copy link
Member

pi0 commented May 30, 2019

This PR has been published in v4.6.0

@kazazes kazazes deleted the auth0-audience-fix branch April 28, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants