fix(types): extend from AxiosStatic
#319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is: TS2339: Property 'CancelToken' does not exist on type 'NuxtAxiosInstance'.
Codecov Report
@@ Coverage Diff @@
## dev #319 +/- ##
===================================
Coverage 100% 100%
===================================
Files 1 1
Lines 30 30
Branches 13 13
===================================
Hits 30 30Continue to review full report at Codecov.
|
ricardogobbosouza
approved these changes
Jan 11, 2020
|
Resolve #322 |
kevinmarrec
approved these changes
Jan 11, 2020
kevinmarrec
suggested changes
Jan 11, 2020
I don't understand, Why the import need be changed? |
|
@MrJmpl3 First line of the file, |
kevinmarrec
suggested changes
Jan 11, 2020
types/index.d.ts
Outdated
| @@ -1,8 +1,8 @@ | |||
| import { AxiosError, AxiosInstance, AxiosRequestConfig, AxiosResponse } from 'axios' | |||
| import { AxiosError, AxiosStatic, AxiosRequestConfig, AxiosResponse } from 'axios' | |||
There was a problem hiding this comment.
Suggested change
| import { AxiosError, AxiosStatic, AxiosRequestConfig, AxiosResponse } from 'axios' | |
| import { AxiosError, AxiosRequestConfig, AxiosResponse, AxiosStatic } from 'axios' |
pi0
approved these changes
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is: TS2339: Property 'CancelToken' does not exist on type 'NuxtAxiosInstance'.
https://axios.nuxtjs.org/usage#cancel-token
const { CancelToken } = this.$axios