Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bridge compatibility #80

Merged
merged 1 commit into from Mar 10, 2023
Merged

fix: bridge compatibility #80

merged 1 commit into from Mar 10, 2023

Conversation

ricardogobbosouza
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #80 (c19b76b) into main (6ef7100) will increase coverage by 18.46%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             main       #80       +/-   ##
============================================
+ Coverage   81.53%   100.00%   +18.46%     
============================================
  Files           2         2               
  Lines          65        68        +3     
  Branches        7         7               
============================================
+ Hits           53        68       +15     
+ Misses         12         0       -12     
Impacted Files Coverage Δ
src/module.ts 100.00% <100.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ricardogobbosouza ricardogobbosouza changed the title fix: compatibility fix: bridge compatibility Mar 9, 2023
@ricardogobbosouza ricardogobbosouza merged commit c902dc3 into main Mar 10, 2023
3 checks passed
@ricardogobbosouza ricardogobbosouza deleted the fix-compatibility branch March 10, 2023 18:07
@MartinX3
Copy link

@ricardogobbosouza

 ERROR  [unhandledRejection] Cannot read properties of undefined (reading 'tap')                                                                                                  11:27:49

  at node_modules/.pnpm/eslint-webpack-plugin@4.0.0_p72rhxqnkxdgq5hcokxg4t4deu/node_modules/eslint-webpack-plugin/dist/index.js:120:42
  at SyncHook.eval [as call] (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:87:1)
  at SyncHook.lazyCompileHook (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/Hook.js:154:20)
  at Compiler.newCompilation (node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:631:26)
  at node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:667:29
  at AsyncSeriesHook.eval [as callAsync] (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
  at AsyncSeriesHook.lazyCompileHook (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/Hook.js:154:20)
  at Compiler.compile (node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:662:28)
  at node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Watching.js:77:18
  at _next1 (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:25:1)

@argoyle
Copy link

argoyle commented Mar 30, 2023

Any update on the problem @MartinX3 reported above?

@MartinX3
Copy link

@argoyle I deactivated this modul and wait for a response by @ricardogobbosouza

@argoyle
Copy link

argoyle commented Mar 30, 2023

Yes, me too. But it removes the eslint-findings during "regular" dev and I have to run linting manually for now. 😄

@MartinX3
Copy link

I use commitlint as git hook, run the lints in "preserve" and "prebuild" and also activated linting on save in IntelliJ as action on save :)

@xel1045
Copy link

xel1045 commented Oct 23, 2023

Nuxt Bridge use Webpack 4 under the hood, so eslint-webpack-plugin@^2.0.0 should be used, but ^4.0.1 is specified by @nuxtjs/eslint-module.

As a workaround, you could add a resolution to your package.json to force v2 to be installed:

    "resolutions": {
        "eslint-webpack-plugin": "^2.0.0"
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants