Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icons import syntax doesnt support pro solid icons #3

Closed
pimlie opened this issue Jan 24, 2020 · 2 comments
Closed

New icons import syntax doesnt support pro solid icons #3

pimlie opened this issue Jan 24, 2020 · 2 comments

Comments

@pimlie
Copy link
Member

pimlie commented Jan 24, 2020

Solid icons comes both in a free as pro variant, currently only free is supported.

@pimlie
Copy link
Member Author

pimlie commented Jan 26, 2020

@vaso2 @pi0 Could you guys share your thoughts about the best syntax to fix this?

  icons: {
    solidPro: true // special key
  }

// or

  pro: true, // top level key, meaning use pro when possible (only has use for solid icons though)
  icons: {
    solid: true
  }

// or

  icons: {
   solid: [
      'faHome'
    ],
    solid: { // support both array as object config, dont like the icons prop twice
      pro: true,
      icons: [
        'faHome'
      ]
    }
  }

any other ideas? My prefs would be 2 I think.

@pimlie
Copy link
Member Author

pimlie commented Feb 8, 2020

Have opted to go for adding a new config key proIcons

@pimlie pimlie closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant