fix(module): warn about head as a function in nuxt config is not supported #14
Conversation
|
test results. |
lib/module.js
Outdated
| @@ -51,6 +51,7 @@ module.exports = async function gtmModule (_options) { | |||
| script = `if(!window._gtm_init){window._gtm_init=1;${script}}` | |||
|
|
|||
| // Add google tag manager <script> to head | |||
| this.options.head = typeof this.options.head === 'function' ? {} : this.options.head | |||
There was a problem hiding this comment.
This silently removes user-provided head function. Meanwhile working on a nuxt enhancement to allow providing a custom head in a better way (app/head.js) maybe adding a warning like [@nuxtjs/gtm] head is provided as a function which is not supported by this module at the moment. Removing user-provided head. (or something like this)
There was a problem hiding this comment.
okay i found it. so i try to fix this right way that support.
There was a problem hiding this comment.
i think that your better way is good alternative. so i'm gonna remove to my head function in nuxt.config.js. Inadvertently i made you confused, but i want to improve to about this.
thanks.
There was a problem hiding this comment.
No i mean this PR idea is awesome because users should be aware of this current incompatibility. If you add the warning, would be happy to merge it for now :)
|
i added warning :)
|
lib/module.js
Outdated
| if (typeof this.options.head === 'function') { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('[@nuxtjs/gtm] head is provided as a function which is not supported by this module at the moment. Removing user-provided head.') | ||
| this.options.head = typeof this.options.head === 'function' ? {} : this.options.head |
There was a problem hiding this comment.
I think this typeof check is not necessary anymore (upper-level condition is checking)
There was a problem hiding this comment.
am i try to first Open Source PR of my develop life.. please understand to insufficient processes.
There was a problem hiding this comment.
NP! Happy to hear you are willing to do more OSS stuff :) Wish to see more contributions by you 👍
There was a problem hiding this comment.
i'm glad you, i will try to fix and improve more OSS!
thanks
pi0
changed the title
pi0
changed the title
This PR is solved problem to execute when head property is function in nuxt.config.js and then added head property code in nuxt.config.js which necessary test codes