refactor(lazy): include fallback locale messages in the main bundle #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optimization to avoid including the messages for the fallback locale in Nuxt state. Since the messages for the fallback locale are **always required** when "vueI18n.fallbackLocale" is defined we can include it in the main bundle and avoid making all server-side responses include it separately. The amount of data is the same in both cases but this way we can take advantage of browser caching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization to avoid including the messages for the fallback
locale in Nuxt state.
Since the messages for the fallback locale are always required when
"vueI18n.fallbackLocale" is defined we can include it in the main bundle
and avoid making all server-side responses include it separately. The
amount of data is the same in both cases but this way we can take
advantage of browser caching.