Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): migrate docs to Nuxt Content #864

Merged
merged 8 commits into from Aug 26, 2020

Conversation

debs-obrien
Copy link

@pi0 migration of docs to content including image and spanish lang

@rchl
Copy link
Collaborator

rchl commented Aug 25, 2020

Wow, thank you. 👍

I'll review after kid goes to bed.
I only wonder about whether the links will change and whether we should address that with some redirects if so.

@debs-obrien
Copy link
Author

no problem @rchl although I must admit it was a time consuming one especially with multi lang.

url's are all exactly the same so shouldn't be any problem. only difference is vuepress puts a .html at the end and content doesn't. so you shouldn't need to do any redirects.

@rchl
Copy link
Collaborator

rchl commented Aug 25, 2020

@debs-obrien Do you also have the full-size logo in SVG format?
I think we should also update logo used in the readme so that it's consistent.
We could handle that separately of course but it's nice to have SVG also for authoring.

@rchl
Copy link
Collaborator

rchl commented Aug 25, 2020

Is the docs Nuxt missing @nuxtjs/tailwindcss dependency?
Also getting:

warning "@nuxt/content-theme-docs > @tailwindcss/typography@0.2.0" has unmet peer dependency "tailwindcss@^1.5.0".

@rchl
Copy link
Collaborator

rchl commented Aug 25, 2020

No worries about that warning if you don't know the answer. I've looked into it and it's a bit complicated system of dependencies. :)

@rchl
Copy link
Collaborator

rchl commented Aug 26, 2020

Looks good to me apart from nuxt/content#412 but that's not a blocker and maybe we could also add SVG version of the icon.png to the repo so that we have it in case we need to generate different image sizes.

@debs-obrien
Copy link
Author

done. commit message should have said icon not logo

@rchl
Copy link
Collaborator

rchl commented Aug 26, 2020

No problem. It's all gonna be squashed anyway.

@rchl rchl changed the title Feat/content docs feat(docs): migrate docs to Nuxt Content Aug 26, 2020
@rchl rchl merged commit affb845 into nuxt-modules:master Aug 26, 2020
@debs-obrien debs-obrien deleted the feat/content-docs branch August 26, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants