Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@nuxtjs/bootstrap-vue] override link control to use nuxt-link #45

Closed
pimlie opened this issue Jun 26, 2017 · 3 comments
Closed

[@nuxtjs/bootstrap-vue] override link control to use nuxt-link #45

pimlie opened this issue Jun 26, 2017 · 3 comments

Comments

@pimlie
Copy link
Member

pimlie commented Jun 26, 2017

As nuxt.js uses a <nuxt-link/> component instead of <router-link/>, shouldn't the link component in @nuxtjs/bootstrap-vue module use is="nuxt-link" instead of is="router-link"?

As far as I see at the moment it doesnt matter much as <nuxt-link/> does not provide extra functionality. Also this can probably not be fixed without changes in bootstrap-vue?

This feature request is available on Nuxt.js community (#c29)
@pi0
Copy link
Member

pi0 commented Jun 26, 2017

Hi. Actually, links are more complicated than this. BootstrapVue also has a <b-link> helper component. Will reopen issue when nuxt-link has more functionality then deciding the best way for integration. BTW right now usage is safe and equal :)

@pi0 pi0 closed this as completed Jun 26, 2017
@pimlie
Copy link
Member Author

pimlie commented Jun 26, 2017

As I understand that this repository is in full-swing development, maybe it would be an idea to add a ToDo/Known issue (or similar) section to the README of a modules for things like this (and #43 with the icon module).

Hopefully that would prevent other people from repeating these questions :)

@pi0
Copy link
Member

pi0 commented Jun 26, 2017

We are adding a modules section to nuxt.js website. Good idea mentioning such todos in each modules' page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants