Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-tag-manager): fix respectDoNotTrack #295

Merged
merged 1 commit into from
Jul 13, 2019

Conversation

LaurentTreguier
Copy link
Contributor

The condition for initializing page tracking doesn't work properly:

!this.options.respectDoNotTrack && this.options.pageTracking && !this.hasDNT()

Using && everywhere means that setting respectDoNotTrack to true will prevent the entire condition from ever resolving to true, even if the user does not have the "do not track" setting to true.
Setting respectDoNotTrack to true means that the condition will only resolve to true if the user disables "dot not track" (and thus means that the user's "do not track" setting is then respected)

@pi0
Copy link
Member

pi0 commented Jul 13, 2019

Thanks!

@pi0 pi0 merged commit 56cb078 into nuxt-community:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants