feat: improve types #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$moment` is injected using nuxt `inject` method and is therefore also available in `vuex`.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 13 13
Branches 2 2
=====================================
Hits 13 13Continue to review full report at Codecov.
|
This makes all the ways to use moment type-safe, e.g. this is now type-safe: `this.$moment.duration(this.$moment(moment1).diff(moment2)).humanize()`
|
@kevinmarrec As you made the initial types, could you take a look at this? |
ricardogobbosouza
requested changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$momentis injected using nuxtinjectmethod and is therefore also available invuex.This adds types to the
vuexstore.Also no longer limit the type to
(input?: MomentInput, format?: MomentFormatSpecification, language?: string, strict?: boolean): Momentbut usetypeof moment.This makes it possible to do something like
this.$moment.duration().The README is updated to contain info about how to use this module with typescript.
I was wondering why
this.$momentwas untyped and found out you have to add@nuxtjs/momentto thetypesarray in yourtsconfig.json. Thought it would make sense to include this in the README.