feat: improvements #8
Conversation
|
|
||
| export default (ctx, inject) => { | ||
| inject('moment', moment) |
There was a problem hiding this comment.
This will introduce unnecessary extra load to each SSR request.
There was a problem hiding this comment.
So you'd vote to not inject moment (but using Vue.prototype instead)?
There was a problem hiding this comment.
Yes. I'm aware of the nuxt reload problem. Because of shared Vue instance, any config change for moment module is not being applied unless stop/start nuxt again. Anyway, I think it worth to fix the root problem instead of making production builds slower. We have 3 options:
- For now, use
injectto prevent that problem and accept extra load until Nuxt.js fix - Use a conditional if for the template to use non-inject method for production only
- Just making users aware of such development inconsistency and keep it as is
There was a problem hiding this comment.
Because several issues stated that ppl want to use it with ctx, so also on server side.
There was a problem hiding this comment.
@manniL Honestly this was not the purpose of this module and moment can be easily imported whenever needed which is fully SSR safe too. BTW I agree with that. Let's keep using inject :)
|
I don't get why the test are failing... |
|
@manniL I'll fix tests on master as they are failing there too |
|
How to use this module inside a store? |
Key features:
injectdefaultLocaleoptionResolves #6
Resolves #5
Resolves #4
Resolves #3