perf: Register global mixins from plugins

Follow Vue doc's recommendations for preventing duplicate global mixins application: https://vuejs.org/v2/guide/mixins.html#Global-Mixin
nuxt-modules · Jul 20, 2019 · 2ceb8e4 · 2ceb8e4
1 parent 2d1d729
commit 2ceb8e4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/src/plugins/routing.js b/src/plugins/routing.js
@@ -116,15 +116,20 @@ function getRouteBaseNameFactory (contextRoute) {
   }
 }
 
-Vue.mixin({
-  methods: {
-    localePath: localePathFactory('$i18n', '$router'),
-    switchLocalePath: switchLocalePathFactory('$i18n'),
-    getRouteBaseName: getRouteBaseNameFactory()
+const plugin = {
+  install(Vue) {
+    Vue.mixin({
+      methods: {
+        localePath: localePathFactory('$i18n', '$router'),
+        switchLocalePath: switchLocalePathFactory('$i18n'),
+        getRouteBaseName: getRouteBaseNameFactory()
+      }
+    })
   }
-})
+}
 
 export default ({ app, route }) => {
+  Vue.use(plugin)
   app.localePath = localePathFactory('i18n', 'router')
   app.switchLocalePath = switchLocalePathFactory('i18n')
   app.getRouteBaseName = getRouteBaseNameFactory(route)

diff --git a/src/plugins/seo.js b/src/plugins/seo.js
@@ -1,6 +1,12 @@
 import Vue from 'vue'
 import { nuxtI18nSeo } from './seo-head'
 
-Vue.mixin({
-  head: nuxtI18nSeo
-})
+const plugin = {
+  install(Vue) {
+    Vue.mixin({
+      head: nuxtI18nSeo
+    })
+  }
+}
+
+Vue.use(plugin)