Wait for lazy loading promises #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkodev
reviewed
Dec 20, 2018
src/templates/utils.js
Outdated
| @@ -20,9 +20,10 @@ export async function loadLanguageAsync (i18n, locale) { | |||
| try { | |||
| const module = await import(/* webpackChunkName: "lang-[request]" */ '~/<%= options.langDir %>' + file) | |||
| const messages = module.default ? module.default : module | |||
| i18n.setLocaleMessage(locale, typeof messages === 'function' ? await Promise.resolve(messages()) : messages) | |||
| let result = typeof messages === 'function' ? await Promise.resolve(messages()) : messages | |||
There was a problem hiding this comment.
Thanks for the feedback. I changed that.
Closed
|
Thanks @Alex--C and sorry for the delay! |
No problem - thank you for the merge! :D |
farnabaz
added a commit
to farnabaz/i18n-module
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, lazy loaded locales should be able to return a promise. Doing this creates a warning message ever since nuxt switched to https://github.com/Rich-Harris/devalue .
This pull request prevents this warning. If lazy loading returns a promise, it waits for it before returning from
loadLanguageAsyncand returns the resolved value instead.Resolves nuxt/nuxt#4424 . Related: #161 .