Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates correct baseroute for switchlocalepath #193

Merged
merged 2 commits into from
Jan 20, 2019

Conversation

dipsaus9
Copy link

Old version didn't create correct object for the router.resolve by Vue.
Params should start with a 0 according to the Vue specs. Solved this issue by copying the route object and changing the params. Resulting in not creating warnings for each file and component being checked by Webpack.

Solution:

Create a copy of the route by substracting the params element. Params element has a pathMatch value. If not this will result in undefined and Vue will handle this the correct way. Otherwise baseRoute will result in a valid url and won't start a warning. Other checks will remain the same.

@paulgv paulgv merged commit 909062f into nuxt-modules:master Jan 20, 2019
@paulgv
Copy link
Collaborator

paulgv commented Jan 20, 2019

Thanks @dipsaus9 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants