Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta og:locale shouldn't contain name property #224

Closed
honzabilek4 opened this issue Feb 16, 2019 · 0 comments · Fixed by #225
Closed

Meta og:locale shouldn't contain name property #224

honzabilek4 opened this issue Feb 16, 2019 · 0 comments · Fixed by #225

Comments

@honzabilek4
Copy link

Version

v5.3.0

Reproduction link

https://codesandbox.io/s/z38klo3lrx

Steps to reproduce

Meta tags are included by default, when using the plugin.

What is expected ?

The og:locale meta tag should look like following:
<meta property="og:locale" content="en_GB" />
More info:
http://ogp.me/#optional

What is actually happening?

The tag has currently the following format:
<meta data-n-head="true" data-hid="og:locale" name="og:locale" property="og:locale" content="en_US"> Where the name is an extraneous attribute and the whole tag is being ignored.

Here's an output from facebook sharing debugger:
Screenshot 2019-02-16 at 15.22.25.png

Additional comments?

Is there any reason why the name attribute is present?
If not, I'll add a pull request for this.

This bug report is available on Nuxt community (#c206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant